Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent CLI command to remove a stale node #17691

Merged
merged 2 commits into from
May 20, 2024
Merged

Add agent CLI command to remove a stale node #17691

merged 2 commits into from
May 20, 2024

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented May 17, 2024 •
edited

Summary
  • Adds a new command remove-stale-node to netdatacli. It takes as a parameter a machine guid or a node id and it will unregister this node from the cloud
  • Checks and prevents the local agent (parent) from being removed
  • Checks and prevents a live child from being removed

@stelfrag stelfrag marked this pull request as ready for review May 17, 2024 11:53
@stelfrag stelfrag marked this pull request as draft May 17, 2024 12:18
@stelfrag
Do not unregister the localhost
899af7a 
Do not unregister a live node
Make sure we rewrite the ephemeral value when a child reconnects
@stelfrag stelfrag marked this pull request as ready for review May 17, 2024 13:43
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/plugins.d labels May 17, 2024
thiagoftsm
thiagoftsm approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All possible combinations of input are working as expected, LGTM!

@stelfrag stelfrag merged commit 9726ca1 into netdata:master May 20, 2024
125 of 149 checks passed
@stelfrag stelfrag deleted the remove_node branch May 20, 2024 09:13
lechgu pushed a commit to SaladTechnologies/netdata that referenced this pull request May 23, 2024
@stelfrag @lechgu
Add agent CLI command to remove a stale node (netdata#17691)
f467dd5 
* Mark the node as ephemeral in the database
Remove node command

* Do not unregister the localhost
Do not unregister a live node
Make sure we rewrite the ephemeral value when a child reconnects
lechgu pushed a commit to SaladTechnologies/netdata that referenced this pull request May 31, 2024
@stelfrag @lechgu
Add agent CLI command to remove a stale node (netdata#17691)
0cd1a36 
* Mark the node as ephemeral in the database
Remove node command

* Do not unregister the localhost
Do not unregister a live node
Make sure we rewrite the ephemeral value when a child reconnects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees
No one assigned
Labels
area/collectors Everything related to data collection area/daemon area/database collectors/plugins.d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stelfrag @thiagoftsm