Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release 1.45.5 #17689

Merged
merged 11 commits into from
May 21, 2024
Merged

Patch release 1.45.5 #17689

merged 11 commits into from
May 21, 2024

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented May 17, 2024 •
edited

Summary

@github-actions github-actions bot added area/database area/aclk area/ml Machine Learning Related Issues labels May 17, 2024
@vkalintiris
Copy link
Contributor

@stelfrag I'm not sure about releases, but I think we should cherry-pick #17682 as well.

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label May 17, 2024
@stelfrag
Check for empty dimension id from a plugin (netdata#17690)
f5664af 
Check for empty dimension or dimension creation failure and disable plugin

(cherry picked from commit a33b13f)
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/plugins.d labels May 17, 2024
@Ferroin
Copy link
Member

Ferroin commented May 17, 2024

This also needs the following PRs added:

@Ferroin
Copy link
Member

Ferroin commented May 17, 2024

Also, #17495 needs to be included (it should have been included in v1.45.4, but I forgot about it when we were putting that one together).

@ktsaou @stelfrag
fix sender parsing when receiving remote input (netdata#17696)
edaf6b7 
* fix sender parsing when receiving remote input

* moved obsolete statement

(cherry picked from commit f3e0205)
@ilyam8
Copy link
Member

ilyam8 commented May 20, 2024

@stelfrag lets add

@stelfrag
Copy link
Collaborator Author

This also needs the following PRs added:

These two have merge conflicts

@stelfrag
Copy link
Collaborator Author

@stelfrag lets add

This has a merge conflict
go.d windows add "vnode" to config schema #17478

@stelfrag
Copy link
Collaborator Author

@stelfrag lets add

This has a merge conflict go.d windows add "vnode" to config schema #17478

Resolved conflicts for go.d windows add "vnode" to config schema (#17478)

@Ferroin
Correctly handle required compilation flags for dependencies. (netdat…
bb67bd6 
…a#17664)

`target_compile_definitions` can only be used for actual command
line _macro definitions_. But the `*_CFLAGS_OTHER` may contain flags
that are _not_ macro definitions, and when that happens, any use of
`target_compile_definitions` with the relevant `*_CFLAGS_OTHER` variable
will break the build.

Instead, we should be using `target_compile_options` for these
variables.
@Ferroin
Support offline installs in the updater code. (netdata#17648)
3497f0b
@github-actions github-actions bot added the area/build Build system (autotools and cmake). label May 20, 2024
@Ferroin Ferroin marked this pull request as ready for review May 21, 2024 12:37
@Ferroin Ferroin self-requested a review as a code owner May 21, 2024 12:37
@Ferroin Ferroin merged commit 30d0be0 into netdata:v1.45 May 21, 2024
146 of 148 checks passed
@stelfrag stelfrag deleted the patch_release branch May 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferroin Ferroin Awaiting requested review from Ferroin Ferroin is a code owner

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm is a code owner

@ilyam8 ilyam8 Awaiting requested review from ilyam8 ilyam8 is a code owner

Assignees
No one assigned
Labels
area/aclk area/build Build system (autotools and cmake). area/collectors Everything related to data collection area/database area/go area/ml Machine Learning Related Issues area/packaging Packaging and operating systems support area/streaming collectors/go.d.plugin collectors/plugins.d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stelfrag @vkalintiris @Ferroin @ilyam8 @ktsaou