Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a variable in FreeIMPI (WolfSSL support) #17687

Merged
merged 2 commits into from
May 20, 2024

Conversation

thiagoftsm
Copy link
Contributor

Summary

This PR address an issue reported on Slack:

[105/370] Building C object CMakeFiles/freeipmi.plugin.dir/src/collectors/freeipmi.plugin/freeipmi_plugin.c.o
FAILED: CMakeFiles/freeipmi.plugin.dir/src/collectors/freeipmi.plugin/freeipmi_plugin.c.o 
/usr/bin/cc -D_GNU_SOURCE -I/usr/include/uuid -I/home/stelios/git/netdata/cmake-build-debug -I/home/stelios/git/netdata/src -I/usr/include/json-c -I/home/stelios/git/netdata/src/libnetdata/libjudy/src -I/home/stelios/git/netdata/src/libnetdata/libjudy/src/JudyCommon -Wall -Wextra -Wmaybe-uninitialized -g -std=gnu11 -fdiagnostics-color=always -ffunction-sections -fdata-sections -Wno-builtin-macro-redefined -fexceptions -MD -MT CMakeFiles/freeipmi.plugin.dir/src/collectors/freeipmi.plugin/freeipmi_plugin.c.o -MF CMakeFiles/freeipmi.plugin.dir/src/collectors/freeipmi.plugin/freeipmi_plugin.c.o.d -o CMakeFiles/freeipmi.plugin.dir/src/collectors/freeipmi.plugin/freeipmi_plugin.c.o -c /home/stelios/git/netdata/src/collectors/freeipmi.plugin/freeipmi_plugin.c
/home/stelios/git/netdata/src/collectors/freeipmi.plugin/freeipmi_plugin.c:108:5: error: 'protocol_version' redeclared as different kind of symbol
  108 | int protocol_version = -1;      // IPMI_MONITORING_PROTOCOL_VERSION_1_5, etc. or -1 for default
      |     ^~~~~~~~~~~~~~~~
In file included from /home/stelios/git/netdata/src/libnetdata/ssl/ssl.h:32,
                 from /home/stelios/git/netdata/src/libnetdata/libnetdata.h:486,
                 from /home/stelios/git/netdata/src/collectors/freeipmi.plugin/freeipmi_plugin.c:22:
/usr/include/wolfssl/ssl.h:761:5: note: previous definition of 'protocol_version' with type 'enum AlertDescription'
  761 |     protocol_version                =  70,
Test Plan
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/freeipmi labels May 16, 2024
stelfrag
stelfrag previously approved these changes May 16, 2024
Copy link
Member

@ilyam8 ilyam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed

else if (protocol_version < 0 || protocol_version == IPMI_MONITORING_PROTOCOL_VERSION_1_5) {

@ilyam8 ilyam8 merged commit 834cb82 into netdata:master May 20, 2024
125 of 149 checks passed
@thiagoftsm thiagoftsm deleted the freeimpi_wolfssl branch May 20, 2024 17:31
lechgu pushed a commit to SaladTechnologies/netdata that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection collectors/freeipmi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants