Restructure packaging related files to better reflect usage. #17678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/packaging
vkalintiris
reviewed
May 16, 2024
| @@ -9,6 +9,8 @@ set(CPACK_DEBIAN_DEBUGINFO_PACKAGE NO) | |||
|
|
|||
| set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS YES) | |||
|
|
|||
| set(PKG_FILES "${CMAKE_SOURCE_DIR}/packaging/cmake/pkg-files") | |||
There was a problem hiding this comment.
This is not really needed, is it? I think can use a single definition from the main CMakeLists.txt file.
There was a problem hiding this comment.
It probably isn’t needed, I just kind of forgot it was there. In the the initial version of this change I had forgotten to modify the main CMakeLists file, and when I fixed that I forgot to remove this line in the packaging file. I’ll update the PR to exclude it.
vkalintiris
reviewed
May 30, 2024
Ferroin
force-pushed
the
pkg-files-migration
branch
from
4f5d011
to
bb6b757
Compare
|
Rebased to resolve merge conflict. |
vkalintiris
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is prep-work for eventual CPack RPM support.
The idea here is to group files used for packaging based on the packaging infrastructure they are used for and clearly organize them under a specific hierarchy within the CMake files.
This should be a non-semantic change, with no functional change in behavior for either the build process or end users.
Test Plan
CI passes on this PR.