Fixes: #14567 - Export current view of IP Addresses #15659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Apr 15, 2024
jeremystretch
requested changes
May 20, 2024
jeremystretch
requested changes
May 29, 2024
It was added clearLinkParams to clear button.
arthanson
requested changes
May 30, 2024
|
I tested it. When I exported, I got only one IP address.
|
|
Note: Need to clear and update browser cache before trying, not sure why this is needed. |
|
I checked out to another branch and exported the current view. Then, I went back to the branch that fixed the export current view. Refreshing the page was necessary for it to work correctly. |
jeremystretch
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14567
It added a script in "table_controls_htmx.html" to add the parameters to the URL (changing the htmx behavior).
Another script was created in "export.html" to append the parameters to the HREF to export the current view.
It was tested exporting devices, IP Address, and IP Range, with and without a quick search.