Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-patch:9.1.{0414,0416} #28790

Merged
merged 1 commit into from
May 17, 2024
Merged

vim-patch:9.1.{0414,0416} #28790

merged 1 commit into from
May 17, 2024

Conversation

luukvbaal
Copy link
Contributor

@luukvbaal luukvbaal commented May 16, 2024

vim-patch:9.1.0414: Unable to leave long line with 'smoothscroll' and 'scrolloff'

Problem: Unable to leave long line with 'smoothscroll' and 'scrolloff'.
Corrupted screen near the end of a long line with 'scrolloff'.
(Ernie Rael, after 9.1.0280)
Solution: Only correct cursor in case scroll_cursor_bot() was not itself
called to make the cursor visible. Avoid adjusting for
'scrolloff' beyond the text line height (Luuk van Baal)

vim/vim@b32055e

vim-patch:9.1.0416: some screen dump tests can be improved

Problem: some screen dump tests can be improved (after 9.1.0414)
Solution: Make sure screen state changes properly and is captured in the
screen dumps (Luuk van Baal)

vim/vim@2e64273

@github-actions github-actions bot added the vim-patch See https://neovim.io/doc/user/dev_vimpatch.html label May 16, 2024
@luukvbaal
Copy link
Contributor Author

luukvbaal commented May 16, 2024

Pending vim/vim#14788. Also, for the FIXME's, the sympton is slightly different for us but the cause is the same. Instead of the blank screen Vim produces, Nvim keeps an(also incorrect) skipcol == 0 screen state. Ctrl-L recovers the expected screen state in both Vim and Nvim.

… 'scrolloff'

Problem:  Unable to leave long line with 'smoothscroll' and 'scrolloff'.
          Corrupted screen near the end of a long line with 'scrolloff'.
          (Ernie Rael, after 9.1.0280)
Solution: Only correct cursor in case scroll_cursor_bot() was not itself
          called to make the cursor visible. Avoid adjusting for
          'scrolloff' beyond the text line height (Luuk van Baal)

vim/vim@b32055e

vim-patch:9.1.0416: some screen dump tests can be improved

Problem:  some screen dump tests can be improved (after 9.1.0414)
Solution: Make sure screen state changes properly and is captured in the
          screen dumps (Luuk van Baal)

vim/vim@2e64273
@luukvbaal luukvbaal changed the title vim-patch:9.1.0414: Unable to leave long line with 'smoothscroll' and 'scrolloff' vim-patch:9.1.{0414,0416} May 17, 2024
@luukvbaal luukvbaal marked this pull request as ready for review May 17, 2024 18:53
@zeertzjq zeertzjq merged commit 5f9e7ed into neovim:master May 17, 2024
31 checks passed
@github-actions github-actions bot removed the request for review from seandewar May 17, 2024 22:14
Copy link
Contributor

Successfully created backport PR for release-0.10:

@zeertzjq zeertzjq added this to the 0.10.1 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:backport release-0.10 vim-patch See https://neovim.io/doc/user/dev_vimpatch.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants