Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4048: added example to Granules IDs tooltip #1736

Closed
wants to merge 2 commits into from
Closed

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Apr 11, 2024

Overview

What is the feature?

Adds an example to the Granule IDs search tooltip.
Also updated the package-lock.json (which was not updated on a previous unrelated commit and simply removes an unused dependency radix_colors)

What is the Solution?

Straight forward example added.

What areas of the application does this impact?

GranuleFiltersForm.js

Testing

Reproduction steps

  • **Environment for testing:**prod
  • **Collection to test with:**C2799438271-POCLOUD
  1. go to search.sit.earthdata.nasa.gov/search
  2. Search for C2799438271-POCLOUD
  3. try and search for granules using the example (SWOT__01?_26?_10_*)
  4. ensure it shows up in the tooltip when hovering over Granule ID(s)

Attachments

image Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (1b9596c) to head (105ccd5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         727      727           
  Lines       19504    19504           
  Branches     4639     4641    +2     
=======================================
  Hits        17927    17927           
  Misses       1439     1439           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -260,6 +260,11 @@ export const GranuleFiltersForm = (props) => {
<strong>Delimiters:</strong>
{' '}
Separate multiple granule IDs by commas.
<br />
<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single space instead of two between this and the previous element

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eudoroolivares2016 Feels right since that's the separation between bolded words.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think my statement was ambiguous, I just mean I'd prefer to have a single <br /> instead of two for consistency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this spacing looks inconsistent in the code, but is consistent in the display. It's the same number of pixels between each group
Counting pixels in GIMP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks for checking that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the first
is for getting the new line, and the second is for the extra empty line

@eudoroolivares2016
Copy link
Contributor

We decided not to do this was given permission to close by @bnp26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants