-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4048: added example to Granules IDs tooltip #1736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 727 727
Lines 19504 19504
Branches 4639 4641 +2
=======================================
Hits 17927 17927
Misses 1439 1439
Partials 138 138 ☔ View full report in Codecov by Sentry. |
@@ -260,6 +260,11 @@ export const GranuleFiltersForm = (props) => { | |||
<strong>Delimiters:</strong> | |||
{' '} | |||
Separate multiple granule IDs by commas. | |||
<br /> | |||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer single space instead of two between this and the previous element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eudoroolivares2016 Feels right since that's the separation between bolded words.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think my statement was ambiguous, I just mean I'd prefer to have a single <br />
instead of two for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks for checking that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the first
is for getting the new line, and the second is for the extra empty line
We decided not to do this was given permission to close by @bnp26 |
Overview
What is the feature?
Adds an example to the Granule IDs search tooltip.
Also updated the package-lock.json (which was not updated on a previous unrelated commit and simply removes an unused dependency
radix_colors
)What is the Solution?
Straight forward example added.
What areas of the application does this impact?
GranuleFiltersForm.js
Testing
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.Checklist