ci: Consistent tsconfig setup for backend packages and fix pnpm typecheck for composite packages (no-changelog)
#9455
+25
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
reviewed
May 17, 2024
There was a problem hiding this comment.
- These BE packages currently pass typecheck. Let's add a CI check to keep them passing?
@n8n/imap@n8n/client-oauth2@n8n/codemirror-lang@n8n/permissions
-
@n8n/codemirror-langdoesn't need to specifystrict: trueI think. -
node-devhas notypecheckand a non-standardtsconfig-build.json. Not sure how much we care about this one though.
…check` for composite packages (no-changelog)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out of #9450
Review / Merge checklist