Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump mkdirp from 1.0.4 to 3.0.1 #2735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2023

Bumps mkdirp from 1.0.4 to 3.0.1.

Changelog

Sourced from mkdirp's changelog.

Changers Lorgs!

3.0

No default exports, just a named export.

2.1

Export CommonJS module without a .default dangly wart. (A synthetic .default has been added just in case anyone is already relying on that from v2.0.)

2.0

Export hybrid module with TypeScript types.

1.0

Full rewrite. Essentially a brand new module.

  • Return a promise instead of taking a callback.
  • Use native fs.mkdir(path, { recursive: true }) when available.
  • Drop support for outdated Node.js versions. (Technically still works on Node.js v8, but only 10 and above are officially supported.)

0.x

Original and most widely used recursive directory creation implementation in JavaScript, dating back to 2010.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 25, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mkdirp-3.0.1 branch 4 times, most recently from 8a94a28 to 5532ecb Compare May 2, 2023 07:45
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mkdirp-3.0.1 branch from 5532ecb to 621fba2 Compare May 16, 2023 08:12
@rpl
Copy link
Member

rpl commented Jul 19, 2023

@dependabot rebase

Bumps [mkdirp](https://github.com/isaacs/node-mkdirp) from 1.0.4 to 3.0.1.
- [Release notes](https://github.com/isaacs/node-mkdirp/releases)
- [Changelog](https://github.com/isaacs/node-mkdirp/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-mkdirp@v1.0.4...v3.0.1)

---
updated-dependencies:
- dependency-name: mkdirp
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mkdirp-3.0.1 branch from 621fba2 to 023c852 Compare July 19, 2023 19:33
@@ -6,7 +6,7 @@
import path from 'path';

import fs from 'fs-extra';
import asyncMkdirp from 'mkdirp';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand this (and the similar tweak in artifacts.js) is the only change needed to fix the test failure (the changelog also confirms that mkdirp is not only exposing a named export).

@rpl rpl requested a review from willdurand July 20, 2023 12:24
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3ff6488) 99.53% compared to head (5a9cbdf) 99.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2735   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          32       32           
  Lines        1735     1735           
=======================================
  Hits         1727     1727           
  Misses          8        8           
Impacted Files Coverage Δ
src/extension-runners/chromium.js 100.00% <ø> (ø)
src/util/artifacts.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant