Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ask which container a page should be open in when it has no site assigned to it #2530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bradsharp
Copy link

Introduces the select page which prompts the user to select the container they want to use when they open a site without a container already assigned to it. This encourages users to separate out their websites into containers if they wish, a common feature that I want myself and have also seen others ask for.

By default this setting is disabled but it can be enabled by the user if they go into the options menu.

An example of what the select page looks like with default containers:

image

I am not familiar with the localization process but I have edited the json files in the locales submodule. I would appreciate it if someone could explain to me what the intended way to include those is.

@KittyKatt
Copy link

Would this possibly fulfill the AC required to satisfy #2535 ? I've been keeping an eye on this issue for months and it feels like if I was asked to select a container for every tab that is not currently assigned to be auto-opened in a container, then the Ctrl-T new tab behavior would work as expected.

@unrealsolver
Copy link

Would it be possible to have manual rules, as it described here: #2134
The use case is mainly 3rd party apps that does not care about containers when opening a link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants