Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] ✨ Add retry mechanism if all students are not allocated #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

B-kash
Copy link

@B-kash B-kash commented May 13, 2024

Summary

Add retry mechanism incase of remaining students allocation

Pull request type

Please try to limit your pull request to one type, and submit multiple pull requests if needed.

Please tick the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behaviour?

Please describe the behaviour that needs to be modified or linked to a relevant issue.

Issue Number: 81

What is the current behaviour?

Please describe the changes or updates being made by this pull request.

  • Added a new argument that can be passed called max-retries (Default: 10)
  • Rerun the allocation upto max-retries if not successfully allocated all the students
  • Small code refactoring changes

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have tested the changes locally and they work as intended.
  • I have provided a detailed description of the changes made.
  • I have reviewed the formatting and ensured it follows the project's style guidelines.
  • I have assigned the appropriate labels to the pull request.
  • I have added necessary documentation or updated existing documentation for the changes made.
  • I have addressed code review feedback and resolved any conflicts with the main branch.

Other information

Include screenshots of the component before and after the change.

school_center.py Outdated Show resolved Hide resolved
@B-kash B-kash changed the title Enhancement: ✨ Add retry mechanism incase of remaining students allocation [Enhancement] #81 Add retry mechanism incase of remaining students allocation May 13, 2024
@B-kash B-kash changed the title [Enhancement] #81 Add retry mechanism incase of remaining students allocation [Enhancement] #81 Add retry mechanism if all students are not allocated May 13, 2024
@B-kash B-kash changed the title [Enhancement] #81 Add retry mechanism if all students are not allocated [Enhancement] ✨ Add retry mechanism if all students are not allocated May 13, 2024
@B-kash
Copy link
Author

B-kash commented May 22, 2024

@sumanashrestha is someone going to fix the pipeline and rerun it? Looking at the failed pipeline, it seems like there is a missing token for codecov??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant