Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#84 Fixes of Schools are not plotted in map in streamlit app #90

Merged
merged 4 commits into from
May 15, 2024

Conversation

nirmala-sharma
Copy link
Contributor

@nirmala-sharma nirmala-sharma commented May 6, 2024

Fixes #84

While Filtering data , schools will also shown in map in different color than center when we apply both (school/center) filter .

@sapradhan
Copy link
Collaborator

Using school list like in your first commit is a better idea as school-center-distance has a much larger row count.

Also instead of re-reading from tsv can we use dataframe in tab3? and build a dict[scode , (lat,long)] from from it so that we dont have to traverse school list multiple times

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

…-distance and use dataframe in tab3 instead of re-reading from tsv file
@nirmala-sharma
Copy link
Contributor Author

Using school list like in your first commit is a better idea as school-center-distance has a much larger row count.

Also instead of re-reading from tsv can we use dataframe in tab3? and build a dict[scode , (lat,long)] from from it so that we dont have to traverse school list multiple times

@sapradhan Completed these changes please review again.

@sapradhan
Copy link
Collaborator

thank you @nirmala-sharma
One more request. is it possible to add legend somewhere. Blue marker = school, Red marker = center

@sumanashrestha sumanashrestha merged commit 6dc5e32 into moest-np:main May 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schools are not plotted in map in streamlit app
3 participants