[stdlib] Apply any()/all() for SIMD cases
#2735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, should i have ran the notebook once after clearing the outputs? i noticed the large -diff |
JoeLoser
approved these changes
May 21, 2024
|
!sync |
modularbot
added
the
imported-internally
Signed-off-by: Max Brylski <helehex@gmail.com>
helehex
force-pushed
the
stdlib/apply-any-all
branch
from
03afcfb
to
9e35736
Compare
|
!sync |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in ee0bd6e! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
May 22, 2024
[External] [stdlib] Apply `any()`/`all()` for `SIMD` cases Switch to using the builtin `any()`/`all()` functions instead of `SIMD.reduce_and()`/`SIMD.reduce_or()` where applicable. This simplifies the code *and* reads very nice. I tested the mandelbrot notebook example to ensure it still works. Co-authored-by: Helehex <Helehex@gmail.com> Closes #2735 MODULAR_ORIG_COMMIT_REV_ID: d08203ce31e7d654c29bf09441845e2e1ed007dd
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Apply `any()`/`all()` for `SIMD` cases Switch to using the builtin `any()`/`all()` functions instead of `SIMD.reduce_and()`/`SIMD.reduce_or()` where applicable. This simplifies the code *and* reads very nice. I tested the mandelbrot notebook example to ensure it still works. Co-authored-by: Helehex <Helehex@gmail.com> Closes modularml#2735 MODULAR_ORIG_COMMIT_REV_ID: d08203ce31e7d654c29bf09441845e2e1ed007dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using the builtin
any()/all()functions instead ofSIMD.reduce_and()/SIMD.reduce_or()where applicable. This simplifies the code and reads very nice.I tested the mandelbrot notebook example to ensure it still works.