Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix and feature #439

Merged
merged 5 commits into from
May 31, 2024
Merged

bugfix and feature #439

merged 5 commits into from
May 31, 2024

Conversation

jiaqianjing
Copy link
Contributor

@jiaqianjing jiaqianjing commented May 15, 2024

  1. add traceback info when call llm failed at the retry decorator;
  2. add zhipu function call at the no_stream mode;
  3. remove useless code;
image

… add zhipu function call at the no_stream mode
@jiaqianjing
Copy link
Contributor Author

能不能把你们的 citest 调好,提了那么多次都不成功,完全没有在想贡献的欲望

@zzhangpurdue
Copy link
Collaborator

能不能把你们的 citest 调好,提了那么多次都不成功,完全没有在想贡献的欲望

这里我们想想怎么优化,这里加了一些secrets调用,会导致fork进来的pr,都有这个问题,我们看看怎么拆开这部分吧。
感谢提供意见。

@zzhangpurdue
Copy link
Collaborator

请合并最新的master,已经解决forked repo ci 不通过问题。感谢支持。



@register_llm('glm-4')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep this @register_llm('glm-4') with @register_llm('zhipu')

@zzhangpurdue zzhangpurdue merged commit 3a03f4f into modelscope:master May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants