-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post API for embedding model and fix embedding model wrappers #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz see inline comments and add example configurations in examples/model_configurations/
# Conflicts: # docs/sphinx_doc/en/source/tutorial/203-model.md # docs/sphinx_doc/zh_CN/source/tutorial/203-model.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz fix the typo, others lgtm
# Conflicts: # docs/sphinx_doc/en/source/tutorial/203-model.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add post API for embedding model and fix embedding model wrappers
Description
By default, now the return of embedding model wrappers are
ModelResponse
with list of embeddings.Checklist
Please check the following items before code is ready to be reviewed.