Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when users
createEngine()
or callreload()
with a model that is too large for the device, likely the device would keep generating, ignoring OOM issue and correctness. See #356 and #209.This PR catches such error with
device.lost.then()
, depending on tvmjs to calldevice.destroy()
upon detecting error increateBuffer()
via apache/tvm#17005.We have only observed
createBuffer()
errors and hence will only process such kind of errors for now. Besides, since most OOM errors occur inreload()
, we make the error handling synchronous despite using.then()
by throwing the error at the end ofreload()
if there is one.