Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Einsum #392

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Einsum #392

wants to merge 31 commits into from

Conversation

dc-dc-dc
Copy link
Contributor

@dc-dc-dc dc-dc-dc commented Jan 7, 2024

Proposed changes

Back with a path 馃榿

Took the feedback from the first PR and came back to this problem. Heavily inspired from numpy's optimal path algo, separated the logic to it's own file and added some testing around it. Now we have a more efficient algo that attempts to utilize tensordot whenever possible and defaulting to the previous implementation which I have renamed to einsum_naive. In draft mode for now as I have just gotten most of the tests to pass but still want to go back through the code and simplify wherever possible.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@dc-dc-dc dc-dc-dc force-pushed the einsum branch 4 times, most recently from a690029 to 14f2c48 Compare January 11, 2024 21:27
@dc-dc-dc dc-dc-dc marked this pull request as ready for review January 11, 2024 21:28
@angeloskath
Copy link
Member

@dc-dc-dc this has not been forgotten, just bear with us as we get through PRs and new features. Big PRs like this require a little more time and clearer mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants