-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Einsum #392
Open
dc-dc-dc
wants to merge
31
commits into
ml-explore:main
Choose a base branch
from
dc-dc-dc:einsum
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Einsum #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc-dc-dc
force-pushed
the
einsum
branch
4 times, most recently
from
January 11, 2024 21:27
a690029
to
14f2c48
Compare
@dc-dc-dc this has not been forgotten, just bear with us as we get through PRs and new features. Big PRs like this require a little more time and clearer mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Back with a path 馃榿
Took the feedback from the first PR and came back to this problem. Heavily inspired from numpy's optimal path algo, separated the logic to it's own file and added some testing around it. Now we have a more efficient algo that attempts to utilize
tensordot
whenever possible and defaulting to the previous implementation which I have renamed toeinsum_naive
. In draft mode for now as I have just gotten most of the tests to pass but still want to go back through the code and simplify wherever possible.Checklist
Put an
x
in the boxes that apply.pre-commit run --all-files
to format my code / installed pre-commit prior to committing changes