Translations: force json, convert template, default to existing key #2292
+189
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlamaLad7
suggested changes
May 3, 2024
src/main/kotlin/translations/intentions/ConvertToTranslationIntention.kt
Outdated
Show resolved
Hide resolved
Earthcomputer
requested changes
May 3, 2024
|
We have already dropped support for new features for MC 1.12, so I don't mind support for lang files being unimplemented. |
…ld assist in implementing automatic yarn/mojmap I18n templating in the future
RedNesto
reviewed
May 5, 2024
RedNesto
reviewed
May 10, 2024
src/main/kotlin/translations/sorting/TranslationTemplateConfigurable.kt
Outdated
Show resolved
Hide resolved
Earthcomputer
requested changes
May 10, 2024
| if (translationSettings.isUseCustomConvertToTranslationTemplate) { | ||
| translationSettings.convertToTranslationTemplate.replace("\$key", key) | ||
| } else { | ||
| "net.minecraft.client.resources.I18n.format(\"$key\")" |
There was a problem hiding this comment.
Wasn't the point of adding a checkbox for a custom template to use the mappings manager?
There was a problem hiding this comment.
My understanding from your previous message is that the mappings API isn't ready yet.
I added the checkbox so that when it's ready it can be integrated without requiring users to tick another box when they update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 new translation features (I can split into 3 PRs if needed)
Add Force JSON Translation
For me (and maybe others), the plugin isn't able to detect the Minecraft version and throws "Cannot determine MC version". This option makes it avoid erroring
Add template for the Convert to Translation feature
net.minecraft.client.resources.I18n isn't always desired, this option allows the template string to be changed
Default to existing key when adding duplicate translation text
Scans the translation file for an existing key that matches the translation text and suggests it inside the Convert to Translation dialog
Feature 3 only supports json translation files, support for lang files can be added if desired.
Apologies if there are any stylistic issues, I am not a Kotlin developer