Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metrics leak on the coord nodes #33075

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: metrics leak on the coord nodes #33075

merged 1 commit into from
May 20, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented May 15, 2024 •
edited

issue: #32980

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels May 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2024

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (a9c7ce7) to head (f4f9749).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33075      +/-   ##
==========================================
- Coverage   82.15%   82.11%   -0.04%     
==========================================
  Files        1006     1006              
  Lines      128449   128457       +8     
==========================================
- Hits       105529   105485      -44     
- Misses      18939    18979      +40     
- Partials     3981     3993      +12
Files Coverage Δ
internal/querycoordv2/meta/collection_manager.go 87.68% <100.00%> (+0.03%) ⬆️
internal/querycoordv2/task/scheduler.go 83.94% <100.00%> (-0.62%) ⬇️
pkg/metrics/querycoord_metrics.go 100.00% <100.00%> (ø)
internal/datacoord/meta.go 93.39% <50.00%> (+0.79%) ⬆️
pkg/metrics/datacoord_metrics.go 64.51% <0.00%> (-12.41%) ⬇️

... and 20 files with indirect coverage changes

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

2 similar comments
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
fix: metrics leak on the coord nodes
f4f9749 
Signed-off-by: jaime <yun.zhang@zilliz.com>
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 20, 2024
congqixia
congqixia approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0d99db2 into milvus-io:master May 20, 2024
14 of 15 checks passed
jaime0815 added a commit to jaime0815/milvus that referenced this pull request May 23, 2024
@jaime0815
fix: metrics leak on the coord nodes (milvus-io#33075)
a0aa248 
issue: milvus-io#32980

Signed-off-by: jaime <yun.zhang@zilliz.com>
(cherry picked from commit 0d99db2)
@jaime0815 jaime0815 mentioned this pull request May 23, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 24, 2024
@jaime0815
fix: correct error of metrics stats (#33305)
8990b8b 
issue: #32980
cherry pick from master
pr:  #33075 #33255

---------

Signed-off-by: jaime <yun.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@jiaoew1991 jiaoew1991 Awaiting requested review from jiaoew1991

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaime0815 @sre-ci-robot @congqixia @yanliang567