enhance: Replace Mutex & RWMutex under internal to lock package ones
#33069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also milvus-io#33062 milvus-io#33063 Replace all `sync.RWMutex` & `sync.Mutex` under internal pkg to `lock.RWMutex` & `sync.Mutex` Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
changed the title
lock package ones
mergify
bot
added
dco-passed
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
May 16, 2024
Avoid passing datanode around preparing datanode code directory refactory. Also refine unit test code for same component. The `Await` shall return first before checking the counter number since when lock cost is heavy (using deadlock.RWMutex See PR milvus-io#33069.) case may fail due to long running time submitting tasks. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 16, 2024
Avoid passing datanode around preparing datanode code directory refactory. Also refine unit test code for same component. The `Await` shall return first before checking the counter number since when lock cost is heavy (using deadlock.RWMutex See PR #33069.) case may fail due to long running time submitting tasks. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #33062 #33063
Replace all
sync.RWMutex&sync.Mutexunder internal pkg tolock.RWMutex&sync.MutexSigned-off-by: Congqi Xia congqi.xia@zilliz.com