Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add openblas in install_deps.sh #33065

Merged
merged 1 commit into from
May 17, 2024

Conversation

jiangyinzuo
Copy link
Contributor

@jiangyinzuo jiangyinzuo commented May 15, 2024

Install openblas using apt or yum in scripts/install_deps.sh, update documentations and fix some typos related to build and installation.

issue: #33056, #33066

@sre-ci-robot
Copy link
Contributor

Welcome @jiangyinzuo! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels May 15, 2024
Copy link
Contributor

mergify bot commented May 15, 2024

@jiangyinzuo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@jiangyinzuo jiangyinzuo force-pushed the topics/fix-install-deps branch 2 times, most recently from b976387 to 10b0c2c Compare May 15, 2024 04:50
Install openblas using apt or yum in scripts/install_deps.sh, update
documentations and fix some typos related to build and installation.

issue: milvus-io#33056, milvus-io#33066

Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com>
@mergify mergify bot added the ci-passed label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (d483730) to head (10b0c2c).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33065   +/-   ##
=======================================
  Coverage   82.12%   82.13%           
=======================================
  Files        1005     1005           
  Lines      128131   128131           
=======================================
+ Hits       105227   105239   +12     
+ Misses      18934    18929    -5     
+ Partials     3970     3963    -7     

see 33 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 17, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jiangyinzuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Contributor

czs007 commented May 17, 2024

good job! @jiangyinzuo

@sre-ci-robot sre-ci-robot merged commit 2cc50d8 into milvus-io:master May 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants