enhance: enable parameter for disk index memory factor(#33007) #33009
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrPresent-Han The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
| @@ -61,7 +62,7 @@ func (c *IndexAttrCache) GetIndexResourceUsage(indexInfo *querypb.FieldIndexInfo | |||
| return 0, 0, fmt.Errorf("index type not exist in index params") | |||
| } | |||
| if indexType == indexparamcheck.IndexDISKANN { | |||
| neededMemSize := indexInfo.IndexSize / UsedDiskMemoryRatio | |||
| neededMemSize := int64(float64(indexInfo.IndexSize) * paramtable.Get().QueryNodeCfg.DiskIndexMemoryFactor.GetAsFloat()) | |||
There was a problem hiding this comment.
DISKANN has not been changed. Why need this update?
There was a problem hiding this comment.
ran into oom when loading disk index under the case of LRU
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
MrPresent-Han
force-pushed
the
enable-param-disk-index
branch
from
be2223b
to
88d01b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33009 +/- ##
==========================================
+ Coverage 82.07% 82.10% +0.03%
==========================================
Files 1007 1005 -2
Lines 127668 127655 -13
==========================================
+ Hits 104778 104815 +37
+ Misses 18915 18882 -33
+ Partials 3975 3958 -17
|
related: #33007