Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove l0 delete cache #32990

Merged
merged 1 commit into from
May 21, 2024

Conversation

xiaofan-luan
Copy link
Contributor

fix #32979
remove l0 cache and build delete pk and ts everytime. this reduce the memory and also increase the code readability

@sre-ci-robot sre-ci-robot added area/internal-api size/L Denotes a PR that changes 100-499 lines. approved labels May 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 11, 2024
Copy link
Contributor

mergify bot commented May 11, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 11, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels May 21, 2024
Copy link
Contributor

mergify bot commented May 21, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.15%. Comparing base (c6e2dd0) to head (138a410).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32990      +/-   ##
==========================================
- Coverage   82.19%   82.15%   -0.05%     
==========================================
  Files        1009     1009              
  Lines      128922   128797     -125     
==========================================
- Hits       105970   105815     -155     
- Misses      18963    18975      +12     
- Partials     3989     4007      +18     
Files Coverage Δ
internal/querynodev2/delegator/delegator.go 87.03% <ø> (+0.35%) ⬆️
internal/querynodev2/delegator/delegator_data.go 82.89% <96.15%> (-1.91%) ⬇️

... and 56 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 21, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3d105fc into milvus-io:master May 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants