fix(core): allow hydration of non persistent embedded properties #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
requested changes
May 15, 2024
Added 🫡 |
B4nan
reviewed
May 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5579 +/- ##
==========================================
- Coverage 99.74% 99.73% -0.01%
==========================================
Files 260 260
Lines 17990 17997 +7
Branches 4374 4373 -1
==========================================
+ Hits 17944 17950 +6
- Misses 46 47 +1 ☔ View full report in Codecov by Sentry. |
B4nan
approved these changes
May 20, 2024
tests/features/embeddables/embeddable-custom-types.postgres.test.ts
Outdated
Show resolved
Hide resolved
| @@ -3,7 +3,7 @@ | |||
| exports[`embedded entities with custom types schema: embeddables custom types 1 1`] = ` | |||
| "create table "parent" ("id" serial primary key, "nested_some_value" varchar not null, "nested_deep_some_value" varchar not null, "nested2" jsonb not null, "after" int null, "some_value" varchar null); | |||
|
|
|||
| create table "user" ("id" serial primary key, "savings_amount" numeric(14,2) not null, "after" int null); | |||
| create table "user" ("id" serial primary key, "savings_amount" numeric(14,2) not null, "views" double precision null, "after" int null); | |||
There was a problem hiding this comment.
I believe we agreed the persist: true would be overridden, and in such case there cant be any column. But on a second thought I guess it makes sense to leave it like this.
B4nan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5578