Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make agent hover keyboard accessible #212933

Merged
merged 6 commits into from
May 17, 2024
Merged

make agent hover keyboard accessible #212933

merged 6 commits into from
May 17, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented May 16, 2024 •
edited

fixes #212839

hover.mov

@meganrogge meganrogge self-assigned this May 16, 2024
@meganrogge meganrogge added this to the May 2024 milestone May 16, 2024
@meganrogge meganrogge enabled auto-merge (squash) May 16, 2024 22:25
@meganrogge
Copy link
Contributor Author

actually, if we set the role of toolbar, and add a custom key handler to focus the hover on enter, that would align with the settings editor's way of dealing with this.

@meganrogge meganrogge disabled auto-merge May 16, 2024 22:28
@meganrogge meganrogge marked this pull request as draft May 16, 2024 22:28
@meganrogge meganrogge marked this pull request as ready for review May 17, 2024 17:36
roblourens
roblourens approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@meganrogge meganrogge merged commit 8517ac7 into main May 17, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/show-hover branch May 17, 2024 22:34
johnyongbeyondsoft pushed a commit to johnyongbeyondsoft/vscode that referenced this pull request May 20, 2024
@meganrogge @johnyongbeyondsoft
make agent hover keyboard accessible (microsoft#212933)
cb977c0
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this pull request May 22, 2024
@meganrogge @mustard-mh
make agent hover keyboard accessible (microsoft#212933)
79004e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

chat participant info is not keyboard accessible
2 participants
@meganrogge @roblourens