Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enable typescript isolated modules #212913

Merged
merged 5 commits into from
May 22, 2024

Conversation

SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented May 16, 2024

Fixes #212835

@SimonSiefke SimonSiefke marked this pull request as ready for review May 16, 2024 16:48
@SimonSiefke SimonSiefke changed the title feature: enable isolated modules feature: enable typescript isolated modules May 16, 2024
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is looking good and I am surprised that TSC doesn't complain about all our const-enum usages

@jrieken
Copy link
Member

jrieken commented May 22, 2024

https://www.typescriptlang.org/tsconfig/#references-to-const-enum-members

👀 reading this again and some stackoverflow help resolves the mystery: only ambient/declared const enums are an issue

@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 22, 2024
@jrieken jrieken merged commit ea8e9f0 into microsoft:main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Enabling typescript isolated modules
6 participants