data-grid: changes display from 'flex' to 'grid', and removes flex-direction
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @joacoc! 😊 As I just discussed in the related issue thread I'm actually unsure if this fixes the problems that are described in #473 (or at least I was unable to produce a solution with the changes you provided). Could you describe a bit more of what issue(s) you were facing and how the changes in this PR fixed your issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to relevant issue
This pull request resolves #473
Description of changes
This PR modifies the style of
vscode-data-gridby changing thedisplayproperty fromflextogridand removing theflex-directionproperty.Component gallery test screenshot