Add dark mode handling for table borders #2313
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you hold on this change? I'm doing a large refactor or the color handler code, you can wait for that change is done then you can make your change on top of it. |
|
@Andres-CT98 The new dark color manager code is checked in. Now we can continue this PR to support dark mode on border |
…u/acampostams/dark-mode-handle-borders
…u/acampostams/dark-mode-handle-borders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The color of table borders does not adapt to a dark mode change.
Fix
Added border properties to the dark mode handler. Image borders are omitted.
Cases tested:
Before: Borders do not change color
After: Borders change color to white