Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Ubuntu 24.04 #30826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support Ubuntu 24.04 #30826

wants to merge 1 commit into from

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 15, 2024 •
edited

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch 2 times, most recently from 4562e7e to 1d1be4b Compare May 15, 2024 21:42
@mxschmitt mxschmitt marked this pull request as ready for review May 15, 2024 21:43
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch from a711c28 to 0da438a Compare May 15, 2024 22:08
@mxschmitt mxschmitt force-pushed the feature/support-ubuntu-24.04 branch from 0da438a to be95de6 Compare May 15, 2024 22:10
@mxschmitt mxschmitt added the CQ1 label May 15, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
yury-s
yury-s approved these changes May 15, 2024
View reviewed changes
docs/src/docker.md
```

#### Crawling and scraping

On untrusted websites, it's recommended to use a separate user for launching the browsers in combination with the seccomp profile. Inside the container or if you are using the Docker image as a base image you have to use `adduser` for it.

```bash js
docker run -it --rm --ipc=host --user pwuser --security-opt seccomp=seccomp_profile.json mcr.microsoft.com/playwright:v%%VERSION%%-jammy /bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait until first patch release of 24.04?

docs/src/intro-java.md
@@ -131,7 +131,7 @@ By default browsers launched with Playwright run headless, meaning no browser UI
- Java 8 or higher.
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL).
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, on x86-64 and arm64 architecture. is more clear that it relates to all versions rather than just u24.

docs/src/intro-js.md
@@ -129,7 +129,7 @@ npx playwright --version
- Node.js 18+
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL).
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, with x86-64 or arm64 architecture.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

docs/src/intro-python.md
@@ -102,7 +102,7 @@ pip install pytest-playwright playwright -U
- Python 3.8 or higher.
- Windows 10+, Windows Server 2016+ or Windows Subsystem for Linux (WSL).
- MacOS 12 Monterey, MacOS 13 Ventura, or MacOS 14 Sonoma.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04.
- Debian 11, Debian 12, Ubuntu 20.04 or Ubuntu 22.04, Ubuntu 24.04 - (x86-64 or arm64 architecture).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

packages/playwright-core/src/server/registry/nativeDeps.ts
@@ -450,6 +450,218 @@ export const deps: any = {
'libevent-2.1.so.7': 'libevent-2.1-7',
},
},

'ubuntu24.04-x64': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does our deps generator script work or it's just a copy of 22?

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

27008 passed, 610 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
33 failed
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:189:7 › should not print context options method override in nunit if no options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:195:7 › should print context options method override in nunit if options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:189:7 › should not print context options method override in mstest if no options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:195:7 › should print context options method override in mstest if options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:209:5 › should print a valid basic program in mstest
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:235:5 › should print a valid basic program in nunit
❌ [webkit-library] › library/inspector/cli-codegen-java.spec.ts:118:5 › should print a valid basic program in junit
❌ [webkit-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-pytest.spec.ts:33:5 › should print the correct context options when using a device and lang
❌ [webkit-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified
❌ [webkit-page] › page/page-goto.spec.ts:27:3 › should work with file URL
❌ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:189:7 › should not print context options method override in nunit if no options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:195:7 › should print context options method override in nunit if options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:189:7 › should not print context options method override in mstest if no options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:195:7 › should print context options method override in mstest if options were passed
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:209:5 › should print a valid basic program in mstest
❌ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:235:5 › should print a valid basic program in nunit
❌ [webkit-library] › library/inspector/cli-codegen-java.spec.ts:118:5 › should print a valid basic program in junit
❌ [webkit-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-pytest.spec.ts:33:5 › should print the correct context options when using a device and lang
❌ [webkit-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified
❌ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified
❌ [webkit-page] › page/page-goto.spec.ts:27:3 › should work with file URL

47 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-library] › library/trace-viewer.spec.ts:888:1 › should serve overridden request
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173:3 › should work with Ctrl-clicking
⚠️ [firefox-page] › page/page-event-request.spec.ts:171:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/video.spec.ts:730:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:309:7 › cli codegen › should fill textarea with new lines at the end
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:169:7 › cli codegen › should clear files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:99:5 › mobile viewport › should fire orientationchange event
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:228:7 › cli codegen › should fill
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:57:7 › cli codegen › should click locator.nth
⚠️ [webkit-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:276:7 › cli codegen › should handle dialogs
⚠️ [webkit-page] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:258:7 › cli codegen › should fill japanese text
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:404:7 › cli codegen › should record ArrowDown
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

192451 passed, 8482 skipped, 2619 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxschmitt @yury-s