Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#30798): test(esm): fix import attribute tests #30804

Closed

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › esm.spec.ts:38:5 › should support import assertions
❌ [playwright-test] › esm.spec.ts:60:5 › should support import attributes

27283 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
14 failed
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [firefox-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

49 flaky ⚠️ [chromium-page] › page/page-set-input-files.spec.ts:157:3 › should upload large file with relative path
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [chromium-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:451:7 › cli codegen › should check
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:790:7 › cli codegen › should click button with nested div
⚠️ [chromium-page] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [firefox-page] › page/page-drag.spec.ts:178:5 › Drag and drop › should respect the drop effect
⚠️ [firefox-page] › page/page-mouse.spec.ts:193:3 › should trigger hover state with removed window.Node
⚠️ [firefox-library] › library/emulation-focus.spec.ts:190:12 › should not fire blur events when interacting with more than one page/context
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:169:7 › cli codegen › should clear files
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/page-close.spec.ts:29:3 › should not accept dialog after close
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:228:7 › cli codegen › should fill
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:426:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:473:7 › cli codegen › should generate getByLabel
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:276:7 › cli codegen › should handle dialogs
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:473:7 › cli codegen › should generate getByLabel
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit-page] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [webkit-page] › page/workers.spec.ts:106:3 › should clear upon navigation

168970 passed, 7553 skipped, 2666 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt
Copy link
Member

lets not cherry-pick a test-only change.

@mxschmitt mxschmitt closed this May 20, 2024
@mxschmitt mxschmitt deleted the cherry-pick-1.44-2024-05-14-17-00-21 branch June 3, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants