Update SpinButton layout styles
#31373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 81 | 89 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 653 | 613 | 5000 | |
| Button | mount | 309 | 296 | 5000 | |
| Field | mount | 1158 | 1156 | 5000 | |
| FluentProvider | mount | 718 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 89 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 37 | 33 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 76 | 10 | |
| MakeStyles | mount | 864 | 858 | 50000 | |
| Persona | mount | 1771 | 1742 | 5000 | |
| SpinButton | mount | 1374 | 1374 | 5000 | |
| SwatchPicker | mount | 1520 | 1551 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
May 14, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the affected screenshots
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.normal.chromium.png | 3 | Changed |
SpinButton Converged 260 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| SpinButton Converged.Appearance- filled-darker - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.mouseDownDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.focused.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.mouseDownIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-darker.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.focused.chromium.png | 2878 | Changed |
| SpinButton Converged.Appearance- filled-lighter.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-lighter.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.mouseDownIncrement.chromium.png | 2899 | Changed |
| SpinButton Converged.Appearance- filled-darker - RTL.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-lighter.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- filled-darker - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.mouseDownDecrement.chromium.png | 2899 | Changed |
| SpinButton Converged.Appearance- outline (default) - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-lighter.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- filled-lighter - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default).hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default).focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- filled-lighter.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default).hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default).hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.focused.chromium.png | 2878 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default) - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default).rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-lighter - Dark Mode.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.mouseDownIncrement.chromium.png | 2900 | Changed |
| SpinButton Converged.Appearance- underline - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - RTL.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- outline (default).mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- underline - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- outline (default).mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Appearance- underline.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Appearance- underline - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- underline.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.mouseDownDecrement.chromium.png | 2899 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- underline.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- underline.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.focused.chromium.png | 2878 | Changed |
| SpinButton Converged.Appearance- underline - RTL.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - Dark Mode.mouseDownDecrement.chromium.png | 2900 | Changed |
| SpinButton Converged.Appearance- outline (default) - RTL.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Appearance- underline - RTL.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Max Bound - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Appearance- underline.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Max Bound - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound - Dark Mode.mouseDownIncrement.chromium.png | 2899 | Changed |
| SpinButton Converged.At Max Bound - RTL.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Max Bound.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound - RTL.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Appearance- filled-lighter - High Contrast.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Max Bound.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.mouseDownIncrement.chromium.png | 2899 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.focused.chromium.png | 2878 | Changed |
| SpinButton Converged.At Max Bound.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound - RTL.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound - RTL.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Min Bound - Dark Mode.mouseDownDecrement.chromium.png | 2899 | Changed |
| SpinButton Converged.At Min Bound - RTL.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.At Max Bound.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.At Min Bound.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Disabled - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.At Max Bound - RTL.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Disabled - Dark Mode.mouseDownDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Disabled - Dark Mode.mouseDownIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.At Min Bound.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Disabled - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Disabled - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Disabled - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.At Min Bound.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - RTL.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.Disabled - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.Disabled - RTL.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - Dark Mode.mouseDownDecrement.chromium.png | 2899 | Changed |
| SpinButton Converged.Display Value - Dark Mode.hoverInput.chromium.png | 2848 | Changed |
| SpinButton Converged.Disabled - RTL.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - Dark Mode.hoverDecrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Display Value - High Contrast.hoverDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - Dark Mode.focused.chromium.png | 2878 | Changed |
| SpinButton Converged.Display Value - Dark Mode.rest.chromium.png | 2848 | Changed |
| SpinButton Converged.Display Value - High Contrast.focused.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - Dark Mode.mouseDownIncrement.chromium.png | 2899 | Changed |
| SpinButton Converged.Display Value - High Contrast.mouseDownDecrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - Dark Mode.hoverIncrement.chromium.png | 2848 | Changed |
| SpinButton Converged.Display Value - High Contrast.mouseDownIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - High Contrast.hoverInput.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - RTL.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - RTL.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - RTL.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - High Contrast.rest.chromium.png | 3088 | Changed |
| SpinButton Converged.Display Value - RTL.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Display Value - RTL.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Display Value.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Display Value.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Disabled.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - RTL.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.At Min Bound.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Display Value - RTL.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Display Value.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-darker.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-darker.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Display Value - High Contrast.hoverIncrement.chromium.png | 3088 | Changed |
| SpinButton Converged.Invalid- filled-darker.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-lighter.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-darker.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-darker.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-lighter.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-lighter.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- outline.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- outline.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Invalid- outline.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-darker.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- outline.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Invalid- outline.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Invalid- underline.focused.chromium.png | 1604 | Changed |
| SpinButton Converged.Invalid- underline.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- underline.hoverIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- outline.hoverDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- filled-lighter.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- underline.mouseDownIncrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Invalid- filled-lighter.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Size- medium (default).default.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- underline.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- underline.mouseDownDecrement.chromium.png | 1600 | Changed |
| SpinButton Converged.Invalid- underline.hoverInput.chromium.png | 1594 | Changed |
| SpinButton Converged.Size- small.default.chromium.png | 1604 | Changed |
| SpinButton Converged.Size- medium (default) - RTL.default.chromium.png | 1594 | Changed |
| SpinButton Converged.Disabled - Dark Mode.focused.chromium.png | 2848 | Changed |
| SpinButton Converged.Invalid- filled-lighter.focused.chromium.png | 1594 | Changed |
| SpinButton Converged.Size- small - Dark Mode.default.chromium.png | 2868 | Changed |
| SpinButton Converged.Invalid- filled-lighter.mouseDownIncrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Invalid- outline.rest.chromium.png | 1594 | Changed |
| SpinButton Converged.Size- small - RTL.default.chromium.png | 1604 | Changed |
| SpinButton Converged.Size- small - High Contrast.default.chromium.png | 3115 | Changed |
| SpinButton Converged.Invalid- filled-darker.mouseDownDecrement.chromium.png | 1594 | Changed |
| SpinButton Converged.Custom Width - High Contrast.chromium.png | 1494 | Changed |
| SpinButton Converged.Custom Width - Dark Mode.chromium.png | 1254 | Changed |
There was a problem hiding this comment.
Looks like the issue is that SpinButton uses inline-grid rather than grid
"Pile" is a technique that uses CSS grid to stack elements in a single grid area. This replaces uses absolute positioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Elements in
SpinButtonare aligned via absolute positioning.New Behavior
Elements in
SpinButtonare aligned with CSS grid. Background info.