Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fluent UI Web Components Package Readme for NPM v3 Badge #31371

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Falkicon
Copy link
Contributor

Title: Update Fluent UI Web Components package Readme for NPM v3 Badge

Description: This pull request addresses a specific update to the Fluent UI Web Component Package readme file. The following change has been made:

The version badge in the readme has been updated to reflect the new NPM version v3.0.0-beta.15. This change ensures that the version displayed is current and accurately represents the latest version available for the Fluent UI Web components. This update is confined to the readme file and does not affect any other part of the library. It is a part of routine maintenance to keep the repository's documentation up-to-date and clear for all users.

Previous Behavior
NPM version for Web Components was 2.x.

New Behavior
NPM version for Web Components is 3.0.0 beta 15

Title: Update Fluent UI Web Components package Readme for NPM v3 Badge

Description: This pull request addresses a specific update to the Fluent UI Web Component Package readme file. The following change has been made:

The version badge in the readme has been updated to reflect the new NPM version v3.0.0-beta.15. This change ensures that the version displayed is current and accurately represents the latest version available for the Fluent UI Web components. This update is confined to the readme file and does not affect any other part of the library. It is a part of routine maintenance to keep the repository's documentation up-to-date and clear for all users.
@Falkicon Falkicon requested a review from a team as a code owner May 14, 2024 16:27
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@@ -1,7 +1,7 @@
# Fluent UI Web Components
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
Badge.Appearance - Dark Mode.normal.chromium.png 15 Changed
Slider 2 screenshots
Image Name Diff(in Pixels) Image Type
Slider.Slider Steps Vertical.normal.chromium.png 1 Changed
Slider.Slider Steps.normal.chromium.png 1 Changed
Text 1 screenshots
Image Name Diff(in Pixels) Image Type
Text.Block.normal.chromium.png 995 Changed

Copy link

codesandbox-ci bot commented May 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -1,7 +1,7 @@
# Fluent UI Web Components

[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
[![npm version](https://badge.fury.io/js/%40fluentui%2Fweb-components.svg)](https://badge.fury.io/js/%40fluentui%2Fweb-components)
[![npm version](https://img.shields.io/npm/v/@fluentui/web-components/beta?style=flat-square)](https://www.npmjs.com/package/@fluentui/web-components/v/3.0.0-beta.15)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be pinned to beta to get the auto-published releases from the cron job, I would suggest we also make an issue to change this to latest once the full prod release is pushed.

Suggested change
[![npm version](https://img.shields.io/npm/v/@fluentui/web-components/beta?style=flat-square)](https://www.npmjs.com/package/@fluentui/web-components/v/3.0.0-beta.15)
[![npm version](https://img.shields.io/npm/v/@fluentui/web-components/beta?style=flat-square)](https://www.npmjs.com/package/@fluentui/web-components/v/beta)

Copy link
Contributor Author

@Falkicon Falkicon May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janechu , Changed based on your suggestion. Thanks.

@Falkicon Falkicon requested a review from janechu May 15, 2024 20:58
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update your branch to resolve conflicts. otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants