-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wc-3 branch base update guide #31361
Draft
Hotell
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
Hotell:wc/3/testing-base-changes-with-update
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
wc-3 branch base update guide #31361
Hotell
wants to merge
4
commits into
microsoft:master
from
Hotell:wc/3/testing-base-changes-with-update
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
wc/3/testing-base-changes-with-update
branch
from
May 14, 2024 08:22
7393253
to
68b4ebe
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 14, 2024
@@ -0,0 +1,7 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Badge 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Badge.Appearance - Dark Mode.normal.chromium.png | 15 | Changed |
Text 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Text.Block.normal.chromium.png | 995 | Changed |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Hotell
changed the title
Wc/3/testing base changes with update
wc-3 branch base update guide
May 14, 2024
This was referenced May 17, 2024
Closed
WC3 Dialog: Replaces default rendered close button in ShadowDOM with user-provided close slot
#29648
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WC3 PR Steps to update against master
update your local master branch with latest upstream
git checkout master
git pull -r upstream master
checkout your branch in PR
git checkout <your-pr-branch-name>
interactive rebase against master and mark all commits not created by yourself as
d
( drop )git rebase -i master
d
push your changes to your branch
git push -f origin <your-branch-name>
change PR base from
web-components-3
tomaster
you're done 👌
Related Issue(s)