Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wc-3 branch base update guide #31361

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 14, 2024

WC3 PR Steps to update against master

This PR is a demo of this PR #31234 being re-directed against master branch

  • update your local master branch with latest upstream

    • git checkout master
    • git pull -r upstream master
  • checkout your branch in PR

    • git checkout <your-pr-branch-name>
  • interactive rebase against master and mark all commits not created by yourself as d ( drop )

    • git rebase -i master
    • identify your commits
      • image
    • mark everything else with d
      • image
    • close the interactive rebase page after changes
    • rebase will succeed
  • push your changes to your branch

    • git push -f origin <your-branch-name>
  • change PR base from web-components-3 to master

    • Click on Edit / Click on Edit
    • Click on change base branch and select master / click on change base branch and select master
    • Confirm Change Base Confirm Change Base
    • Remove all non-relevant reviewers ( which were added automatically because your PR contained commits from master ) image
  • you're done 👌

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 14, 2024
@Hotell Hotell force-pushed the wc/3/testing-base-changes-with-update branch from 7393253 to 68b4ebe Compare May 14, 2024 08:22
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
Badge.Appearance - Dark Mode.normal.chromium.png 15 Changed
Text 1 screenshots
Image Name Diff(in Pixels) Image Type
Text.Block.normal.chromium.png 995 Changed

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants