[MRTCore] Add global PrimaryLanguageOverride switch #4181
Conversation
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4181 in repo microsoft/WindowsAppSDK |
|
while doubtful /azp run |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4181 in repo microsoft/WindowsAppSDK |
|
This is needed for PowerToys to fully enable language override |
| static hstring PrimaryLanguageOverride(); | ||
|
|
||
| private: | ||
| static hstring m_language; |
| [contract(MrtCoreContract, 1)] | ||
| runtimeclass ApplicationLanguages | ||
| { | ||
| static String PrimaryLanguageOverride; |
There was a problem hiding this comment.
Has Xaml/WinUI3 been hooked up to use this new API? Or does it all just work?
There was a problem hiding this comment.
I have tested both manually loading resources with ResourceLoader and XAML (by setting x:Uid property and adding appropriate string resource) and it just works. Any additional tests I could do here?
| [contract(MrtCoreContract, 1)] | ||
| runtimeclass ApplicationLanguages | ||
| { | ||
| static String PrimaryLanguageOverride; |
There was a problem hiding this comment.
New API, so where's the test / sample in the peer Windows App SDK Samples repo?
There was a problem hiding this comment.
| } // namespace Microsoft.Windows.ApplicationModel.Resources | ||
|
|
||
| [contract(MrtCoreContract, 1)] | ||
| runtimeclass ApplicationLanguages |
There was a problem hiding this comment.
New API, so please include a markdown file for API review.
There was a problem hiding this comment.
Often better to make a PR with just a markdown spec for review, separate from implementation/test/etc. Streamlines the API Review process for everyone involved
There was a problem hiding this comment.
this is in progress, thanks for pointing out
| { | ||
| hstring ApplicationLanguages::m_language; | ||
|
|
||
| void ApplicationLanguages::PrimaryLanguageOverride(hstring language) |
There was a problem hiding this comment.
Is this file from the generated skeleton from C++/WinRT or hand crafted? Generated files usually have string parameters as 'hstring const& blah' (hstring will cause a deep copy on each call)
After compiling your .idl grab the code from d:\source\repos\windowsappsdk\obj\Debug\x64\...dir-for-this-project...\Generated Files\sources\Microsoft.Windows.ApplicationModel.Resources.ApplicationLanguages.cpp and matching .h, and follow their contained directions.
stefansjfw
force-pushed
the
user/stefansjfw/add_primary_language_override
branch
from
eafa77e
to
410c575
Compare
| @@ -113,4 +113,11 @@ namespace Microsoft.Windows.ApplicationModel.Resources | |||
| static String TargetSize { get; }; | |||
| static String Theme { get; }; | |||
| } | |||
| } // namespace Microsoft.Windows.ApplicationModel.Resources | |||
|
|
|||
| [contract(MrtCoreContract, 1)] | |||
Changing the application language by setting
Windows.Globalization.ApplicationLanguages.PrimaryLanguageOverrideto a specific language is not supported for WASDK unpackaged app, only for packaged ones. To support the same behavior for unpackaged applications similar switch is introduced into WASDK MRTCore module.Sample app used to verify the change: https://github.com/stefansjfw/testwasdk/blob/master/testlocalwinappsdk/App.xaml.cs#L36
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.