Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomEditControl Sample: WinAppSDK Edition #195

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tyduckMSFT
Copy link

@tyduckMSFT tyduckMSFT commented Apr 23, 2022

Description

This is a port of the CustomEditControl sample previously implemented in the UWP samples. Includes a C++/WinRT and C# version of the sample. Addresses request captured in #85.

Target Release

1.2

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@tyduckMSFT
Copy link
Author

/azp run SamplesCI-CustomEditControl

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@tyduckMSFT
Copy link
Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@tyduckMSFT
Copy link
Author

/azp run SamplesCI-CustomEditControl

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rirufa
Copy link

rirufa commented Jul 10, 2022

I run this sample. I found funny behaivor. Sugget window hide caret and text.

Windows App SDK 1.1
Windows 11 Pro 21H2
IME:MS-IME

wrong caret position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants