Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class decorator detection in class fields transform #58554

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

rbuckton
Copy link
Member

This fixes the class fields transform to properly detect original nodes that were decorated class expressions.

Fixes #58436

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 16, 2024
@rbuckton rbuckton marked this pull request as draft May 16, 2024 16:51
@rbuckton
Copy link
Member Author

rbuckton commented May 16, 2024

I found a case that still needs to be addressed. I'll update the PR shortly.
Updated and ready for review.

@rbuckton rbuckton marked this pull request as ready for review May 16, 2024 17:21
@rbuckton rbuckton merged commit a1dfb1a into main May 23, 2024
28 checks passed
@rbuckton rbuckton deleted the fix-58436 branch May 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various bugs with class expressions and JavaScript decorators (code run twice, internal compiler crash)
3 participants