Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Azure Pipelines #4638

Closed
wants to merge 31 commits into from
Closed

Test Azure Pipelines #4638

wants to merge 31 commits into from

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Apr 28, 2024 •
edited

Not for review.

@StephanTLavavej StephanTLavavej added infrastructure Related to repository automation uncharted Excluded from the Status Chart labels Apr 28, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 28, 2024 04:40
@StephanTLavavej StephanTLavavej force-pushed the more-azure branch 2 times, most recently from 20d526c to 9acd056 Compare April 28, 2024 07:11
@StephanTLavavej StephanTLavavej marked this pull request as draft April 28, 2024 07:32
@StephanTLavavej StephanTLavavej marked this pull request as ready for review April 29, 2024 05:48
@StephanTLavavej StephanTLavavej force-pushed the more-azure branch 2 times, most recently from f7411b8 to bb9f485 Compare April 29, 2024 08:07
@StephanTLavavej StephanTLavavej marked this pull request as draft April 29, 2024 09:25
@StephanTLavavej StephanTLavavej marked this pull request as ready for review May 1, 2024 07:00
@StephanTLavavej StephanTLavavej force-pushed the more-azure branch 6 times, most recently from 84c63b8 to c41bb95 Compare May 1, 2024 08:36
@StephanTLavavej StephanTLavavej marked this pull request as draft May 6, 2024 21:41
@StephanTLavavej StephanTLavavej force-pushed the more-azure branch 2 times, most recently from 15ea8f9 to 0c608d1 Compare May 8, 2024 21:47
@StephanTLavavej StephanTLavavej marked this pull request as ready for review May 11, 2024 22:09
@StephanTLavavej StephanTLavavej marked this pull request as draft May 11, 2024 22:25
@StephanTLavavej
Detect provision-image.ps1 failure. [tested]
6402fd9 
Use case-sensitive matching for 'PROVISION_IMAGE_SUCCEEDED'.
@StephanTLavavej
Permanently install PowerShell 7.4.2. [tested]
2632a76 
We need to preserve the original filename 'PowerShell-7.4.2-win-x64.msi' instead of generating 'RANDOM.exe'.
@StephanTLavavej
Download installers to D:\installerTemp. [tested]
08328dc 
CUDA is 3 GB, so this may be helpful.
@StephanTLavavej
Guard against locally running provision-image.ps1. [tested]
0c4ed3a 
This uses a case-sensitive comparison; the default is case-insensitive.
@StephanTLavavej
Inline away the Wait-Shutdown function. [tested]
578d523 
The progress bar message makes the `Write-Host` messages unnecessary.

`-ResourceId $VM.ID` is much shorter than `-ResourceGroupName $ResourceGroupName -Name $Name`, allowing us to directly say `'PowerState/stopped'` without wrapping.

The original implementation in GH 633 (named `Start-WaitForShutdown`) was verbose, justifying a separate function, but now a direct loop is clearer.
@StephanTLavavej
Consistently use $VM.ID. [tested]
d6bb0bc
@StephanTLavavej
Run sysprep with -ScriptString. [tested]
85f3811 
`$ErrorActionPreference` wasn't useful because sysprep is a native command.

`Write-Host` wasn't useful because we aren't printing the message returned by `Invoke-AzVMRunCommand`.

The PowerShell call operator `&` wasn't useful because we aren't expanding any variables here.
@StephanTLavavej
Style: For New-AzVMConfig, use -VMName instead of the alias `-Nam…
6c2dbfc 
…e`. [tested]
@StephanTLavavej
New-AzVm defaults to Trusted Launch as of Azure PowerShell 11.0.0 (…
0a8f3d8 
…November 2023). [verified]

See:
https://techcommunity.microsoft.com/t5/azure-compute-blog/breaking-change-for-vm-amp-vmss-powershell-cli-customers/ba-p/3937037
https://learn.microsoft.com/en-us/powershell/azure/release-notes-azureps?view=azps-11.5.0#azcompute-700
@StephanTLavavej
Give validationBuildOutputLocation a dedicated name, and clean it. …
c05e773 
…[tested]
@StephanTLavavej
Inline create-prdiff.ps1, part 1. [tested]
3ca0599 
No changes except for:

* Drop redundant banner.
* `$DiffFile` was never passed as an argument, so set it as an ordinary variable.
* Indentation.
@StephanTLavavej
Inline create-prdiff.ps1, part 2. [tested]
0efc9fa 
Simplify by using the PowerShell redirection operator `>` instead of `Start-Process`.

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_redirection?view=powershell-7.4#powershell-redirection-operators

Verified that the diff can be applied cleanly.
@StephanTLavavej
Inline create-prdiff.ps1, part 3. [tested]
0309468 
Overhaul messaging.
@StephanTLavavej
Inline create-prdiff.ps1, part 4. [tested]
dbc9096 
Actually name the file format.diff before uploading, as this appears in the zip.
@StephanTLavavej
Inline create-prdiff.ps1, part 5. [tested]
58d93d1 
Name the zip differently from the file within.
@StephanTLavavej
Inline create-prdiff.ps1, part 6. [tested]
4a3ac81 
Style: Avoid Yoda condition when checking `git diff` output.
@StephanTLavavej StephanTLavavej force-pushed the more-azure branch 2 times, most recently from f94fddc to b6e45e9 Compare May 21, 2024 00:35
@StephanTLavavej
Improve provision-image.ps1's synopsis/description. [comment only]
c87c0d2 
They were talking about our old scale set system. Now they talk about hosted pools, and explain the overall process in more detail.
@StephanTLavavej
Require Node.js 22.2.0.
3c8db26
@StephanTLavavej
New pool.
659aeae
@StephanTLavavej
VS 2022 17.11 Preview 1.
9c345ae 
Not yet required - the internal toolset is still 19.40.
@StephanTLavavej
Remove compiler warning suppressions.
b779f79 
MSVC no longer emits warning C4521 'multiple copy constructors specified',
since at least MSVC-PR-368907 on 2021-12-09.
@StephanTLavavej
Remove workarounds for DevCom-10508937 VSO-1913897 "Startup issue whe…
67cb400 
…n building the static debug STL with ASan enabled".
@StephanTLavavej
Work around VSO-2064546 "EDG ICE when deriving from std::num_get".
412579c
@StephanTLavavej StephanTLavavej marked this pull request as ready for review May 22, 2024 04:44
@StephanTLavavej
Copy link
Member Author

/azp run STL-ASan-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Revert "Remove workarounds for DevCom-10508937 VSO-1913897 "Startup i…
b86afaa 
…ssue when building the static debug STL with ASan enabled"."

This reverts commit 67cb400.
@StephanTLavavej
Copy link
Member Author

/azp run STL-ASan-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej StephanTLavavej deleted the more-azure branch May 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure Related to repository automation uncharted Excluded from the Status Chart
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@StephanTLavavej