Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch deps during build; use submodules #533

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Conversation

rickwebiii
Copy link

When building Rust docs for our seal_fhe Rust wrapper crate, the docs fail to compile because docs.rs builds run in a Docker container that doesn't allow network access during compilation. This means third-party dependencies fail to download and the cmake bails.

This change migrates the third party dependencies to be submodules, avoiding the need to fetch them during the build. Rust will blindly package these as source files, so everyone should be happy.

I tested this by building SEAL with every feature enable and compiling tests and benchmarks.

@rickwebiii
Copy link
Author

I should probably add a note in the README to run

git submodule init
git submodule update

after cloning your enlistment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant