Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick Accent] Add Crimean Tatar language #32862

Merged
merged 12 commits into from
Jun 4, 2024

Conversation

cor-bee
Copy link
Contributor

@cor-bee cor-bee commented May 14, 2024

Summary of the Pull Request

Adds Crimean Tatar latin alphabet symbols to Quick Accent (ı, ş, ç, ñ, ğ, İ, ü, â)

PowerToys.Settings_LBXbRao4Th.mp4

PR Checklist

Validation Steps Performed

Observing

Add Crimean Tatar Language
Add Crimean Tatar language
Add Crimean Tatar language
Add Crimean Tatar language
Add Crimean Tatar language
@cor-bee
Copy link
Contributor Author

cor-bee commented May 14, 2024

@microsoft-github-policy-service agree

This comment has been minimized.

@cor-bee
Copy link
Contributor Author

cor-bee commented May 16, 2024

@check-spelling-bot Report

Unrecognized words (1)

CRH

CRH is the Crimean Tatar language ISO code.

However, I don't know how to add exceptions to spellchecker and would be grateful for any help.

This comment has been minimized.

@htcfreek
Copy link
Collaborator

@check-spelling-bot Report

Unrecognized words (1)

CRH

CRH is the Crimean Tatar language ISO code.

However, I don't know how to add exceptions to spellchecker and would be grateful for any help.

@cor-bee
Please update https://github.com/microsoft/PowerToys/blob/main/.github%2Factions%2Fspell-check%2Fexpect.txt .

Add "CHR" to spellcheker false positives (ISO code for Crimean Tatar language)

This comment has been minimized.

This comment has been minimized.

Add "CRH" to spellcheker false positives (ISO code for Crimean Tatar language)
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR.
I've given the PR a try, but it seems that when I select the new character set I get no characters appearing for Quick Accent. Did you give your changes a try?

@jaimecbernardo
Copy link
Collaborator

I don't see GetDefaultLetterKeyCRH called anywhere, so I assume that's the issue 😉

Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
@cor-bee
Copy link
Contributor Author

cor-bee commented Jun 3, 2024

I don't see GetDefaultLetterKeyCRH called anywhere, so I assume that's the issue 😉

Thank you!

With the help of @htcfreek I managed to fix and test that on my computer and it works:

ISOfzPKB5K.mp4

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit a54dc0e into microsoft:main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants