Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included that retrain_full = True does not include the user provided validation data in the docs. #1228 #1245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Included that retrain_full = True does not include the user provided validation data in the docs. #1228 #1245

wants to merge 2 commits into from

Conversation

smty2018
Copy link

Why are these changes needed?

Included that retrain_full = True does not include the user provided validation data in the docs. #1228

Related issue number

Closes #1228

Checks

@smty2018
Copy link
Author

@sonichi can you please review this.

@smty2018 smty2018 requested a review from sonichi October 14, 2023 15:54
sonichi
sonichi approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonichi sonichi requested review from qingyun-wu and a team October 14, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi approved these changes

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include that retrain_full = True does not include the user provided validation data in the docs.
2 participants
@smty2018 @sonichi