Feat/dataroom linktree

[digant2482]

#69. @mfts. I have disabled the ability to create hierarchical datarooms. Please let me know if any changes are needed.

[Aashish-Upadhyay-101]

nice, @digant2482 ping me, after you are done cleaning up !

[digant2482]

nice, @digant2482 ping me, after you are done cleaning up !

Hey @Aashish-Upadhyay-101, all set for review, please let me know, you need any help

[Aashish-Upadhyay-101]

awesome !

[digant2482]

Hi @Aashish-Upadhyay-101, suggested changes are done

[Aashish-Upadhyay-101]

I am half way through the PR already, I will keep you updated here !

[Aashish-Upadhyay-101]

@digant2482 hey, did you scope the Dataroom by Teams?

[digant2482]

@digant2482 hey, did you scope the Dataroom by Teams?

Yes

[Aashish-Upadhyay-101]

I noticed that the dataroom endpoints are outside the team folder in the api,
and you are passing teamId via req.body
could you please put the dataroom inside team folder and get the team's id from req.query ?

[digant2482]

I noticed that the dataroom endpoints are outside the team folder in the api, and you are passing teamId via req.body could you please put the dataroom inside team folder and get the team's id from req.query ?

Hi, Ashish, dataroom was not put inside teams folder because the end users also gets their datarooms from the same API (to avoid code duplication), now the end users won't have teamId, hence it is outside. Please let me know if you need more information

[Aashish-Upadhyay-101]

I have almost reviewed your code, I just have one thing to ask,
you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

[digant2482]

I have almost reviewed your code, I just have one thing to ask, you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

The verification was implemented because of heirarchical datarooms, the things is: for heirarchical datarooms a separate URL was needed to be generated (for navigation purposes), since it was a separate URL it would bypass current verification system, that's was the reason for creation, but I will remove it since we don't need that.

[Aashish-Upadhyay-101]

I have almost reviewed your code, I just have one thing to ask, you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

The verification was implemented because of heirarchical datarooms, the things is: for heirarchical datarooms a separate URL was needed to be generated (for navigation purposes), since it was a separate URL it would bypass current verification system, that's was the reason for creation, but I will remove it since we don't need that.

yes please do it and resolve the conflicts !

[digant2482]

Hi, @Aashish-Upadhyay-101, all requested changes are done.

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well?
If yes, can you please finalize that email-verification PR #197.
Since you have made some changes to verification process, I will use the same for process for datarooms as well

[mfts]

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well?
If yes, can you please finalize that email-verification PR #197.

The email verification is already in production.
You can copy/reuse this function: https://github.com/mfts/papermark/blob/77699f3404c538a25e4450f9d94bc933378cbb9c/pages/api/links/%5Bid%5D/verify-email.ts

[digant2482]

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well?
If yes, can you please finalize that email-verification PR #197.

The email verification is already in production. You can copy/reuse this function: https://github.com/mfts/papermark/blob/77699f3404c538a25e4450f9d94bc933378cbb9c/pages/api/links/%5Bid%5D/verify-email.ts

@Aashish-Upadhyay-101, @mfts All set ready for review

[Aashish-Upadhyay-101]

@mfts looks good to me.
I have reviewed the entire PR.

I would like @mfts to also go through this PR briefly ; )
and let me know !