-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cache-related field from database creation form #42808
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Don't backport" took an action on this PR • (05/16/24)1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation. "Warn authors when publishing large PRs" took an action on this PR • (05/16/24)1 teammate was notified to this PR based on Raphael Krut-Landau's automation. "Notify author when CI fails" took an action on this PR • (05/16/24)1 teammate was notified to this PR based on Raphael Krut-Landau's automation. |
|
7cfd310
to
5bc8a7f
Compare
5bc8a7f
to
2150097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure someone on the backend also gets a look at this before mergning 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good, plus there are no backend changes, what can be better? 😁
Removes the "Default cache duration" field from the database creation form.
Closes #42741