Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache-related field from database creation form #42808

Merged
merged 1 commit into from
May 17, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 16, 2024

Removes the "Default cache duration" field from the database creation form.

Closes #42741

Copy link
Contributor Author

rafpaf commented May 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 16, 2024
@rafpaf rafpaf marked this pull request as ready for review May 16, 2024 22:54
@graphite-app graphite-app bot requested a review from a team May 16, 2024 22:54
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 16, 2024
Copy link

graphite-app bot commented May 16, 2024

Graphite Automations

"Don't backport" took an action on this PR • (05/16/24)

1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

"Warn authors when publishing large PRs" took an action on this PR • (05/16/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Notify author when CI fails" took an action on this PR • (05/16/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented May 16, 2024

Status In Progress ↗︎ 51 / 52
Commit 2150097
Results
⚠️ 3 Flaky
2510 Passed

@rafpaf rafpaf force-pushed the perf/shorten-db-creation-form branch from 7cfd310 to 5bc8a7f Compare May 17, 2024 03:42
@rafpaf rafpaf force-pushed the perf/shorten-db-creation-form branch from 5bc8a7f to 2150097 Compare May 17, 2024 09:55
Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure someone on the backend also gets a look at this before mergning 👍

@rafpaf rafpaf merged commit 5ac502a into master May 17, 2024
109 checks passed
@rafpaf rafpaf deleted the perf/shorten-db-creation-form branch May 17, 2024 12:30
Copy link
Contributor Author

rafpaf commented May 17, 2024

Merge activity

@iethree iethree requested review from a team and piranha May 17, 2024 12:30
@rafpaf rafpaf added this to the 0.50 milestone May 17, 2024
Copy link
Contributor

@piranha piranha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, plus there are no backend changes, what can be better? 😁

@rafpaf rafpaf mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Admin / Performance page ignores the cache duration specified when creating a database
3 participants