Remove location logic from DashboardTabs and use SyncedDashboardTabs #42786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Will be using the logic in #42777 to solve the issues, since they're pretty deeply connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the location out of DashboardTabs will allow the static dashboards to work without changing the URL when it comes to using tabs. I then moved the URL logic to a wrapper component called
SyncedDashboardTabs, which follows the same pattern asSyncedParameterListto use location data, but in a way that keeps it encapsulated in a different component.This is in draft for now, since I need to make sure it still works independently before merging it with the other changes I've made