Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): document theming options in readme #42784

Merged
merged 3 commits into from
May 17, 2024
Merged

feat(sdk): document theming options in readme #42784

merged 3 commits into from
May 17, 2024

Conversation

heypoom
Copy link
Contributor

@heypoom heypoom commented May 16, 2024

Closes #42679

Description

Update the sdk README with possible theming options.

@heypoom heypoom requested a review from a team May 16, 2024 16:25
@heypoom heypoom added the no-backport Do not backport this PR to any branch label May 16, 2024
Copy link
Contributor

@deniskaber deniskaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! But it seems we will need to update this content once #42663 is merged. Or in #42663 itself if this gets merged faster

@heypoom heypoom merged commit 74ec3ee into master May 17, 2024
138 of 147 checks passed
@heypoom heypoom deleted the theming-docs branch May 17, 2024 10:16
@heypoom
Copy link
Contributor Author

heypoom commented May 17, 2024

@deniskaber thanks for the heads-up! Will keep this in mind once both PRs are merged 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/Embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the docs on theming configuration in embedding SDK
2 participants