Drop the "frozen" frontend install during build when in CI #42771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjaglumac
added
.Building & Releasing
.CI & Tests
no-backport
nemanjaglumac
requested review from
camsaul,
dpsutton,
iethree,
uladzimirdev and
a team
uladzimirdev
approved these changes
May 16, 2024
|
bshepherdson
approved these changes
May 17, 2024
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
This PR drops the "frozen"
yarninstall when doing the:frontendbuild step in the CI.Why?
Every time we build the uberjar in the CI, we are always running the
prepare-frontendcomposite action that already includesyarn install --frozen-lockfileso there's no need to repeat this step again during the build process.Furthermore,
prepare-frontendwill respect if commit message contains[ci nocache]whereas the related Clojure code didn't have this distinction.Nothing changes for the local build process.
Additional Info
Slightly related to #37576, even though this will not "buy us" more than a couple of seconds in the CI. This is more of a correctness fix.