changing button height and CP input placeholder #42770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sloansparger
approved these changes
May 16, 2024
mazameli
reviewed
May 16, 2024
There was a problem hiding this comment.
Looks good to me, but, per this thread, could we also increase the width of the Search button to 240px, and have the icon and text be left-aligned?
|
My apologies Maz, I didn't see that thread :(. I'll make those adjustments too! |
npfitz
added
backport
|
@npfitz Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
* changing button height and CP input placeholder * adjusting search button size * translate new placeholder
oisincoveney
pushed a commit
that referenced
this pull request
May 22, 2024
* changing button height and CP input placeholder * adjusting search button size * translate new placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick PR to adjust the size of the search button to be the same as the New button, and changing the placeholder text in the command palette
How to verify
Demo