Fix timeseries chrome overflow #42761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 80687b8...11cee1a.
|
|
romeovs
changed the title
mazameli
requested changes
May 16, 2024
ranquild
reviewed
May 17, 2024
| @@ -87,11 +87,23 @@ describe("TimeseriesBucketPicker", () => { | |||
| expect(getNextBucketName()).toBe("Year"); | |||
| }); | |||
|
|
|||
| it("should allow to show more binning options", async () => { | |||
There was a problem hiding this comment.
Please also add tests for the selected item - when it's within the initial expanded list or not
ranquild
approved these changes
May 17, 2024
|
@mazameli could you take a look? |
mazameli
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42760
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo