-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeseries chrome overflow #42761
Conversation
Codenotify: Notifying subscribers in CODENOTIFY files for diff 80687b8...11cee1a.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but ideally the More…
would be text-brand
in color to distinguish it from the selectable items, and to match what we do in the summarize sidebar and notebook group-by popovers.
@@ -87,11 +87,23 @@ describe("TimeseriesBucketPicker", () => { | |||
expect(getNextBucketName()).toBe("Year"); | |||
}); | |||
|
|||
it("should allow to show more binning options", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add tests for the selected item - when it's within the initial expanded list or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor comments
@mazameli could you take a look? |
Closes #42760
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo