The Admin / Performance page ignores the cache duration specified when creating a database

[rafpaf]

Describe the bug

When you create a database, you're asked to set a cache invalidation policy. But the Admin / Performance page ignores this.

Loom

To Reproduce

In Admin / Databases, create a new database and under advanced options specify a cache duration. Then go to Admin / Performance and look at the database.

Expected behavior: The database's cache invalidation policy in Admin / Performance should be set to Duration, with the specified number of hours.

Actual behavior: The database's cache invalidation policy in Admin / Performance is still "Use default".

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  }
}

Severity

P1

[rafpaf]

The database creation form stores a duration in metabase_database.cache_ttl. This duration is ignored by Admin / Performance page, which uses the cache_config table.

Invalidation policies that were previously stored in metabase_database are copied into cache_config via a migration. However, we still let users insert data into metabase_database.

Related matters:

• Cards have a cache_ttl field which is ignored by Admin / Performance.
• Dead code in the FE: QuestionCacheTTLField, CacheTTLField, PLUGIN_FORM_WIDGETS
• src/metabase/query_processor/middleware/cache.clj refers in a comment to a query-caching-default-ttl setting, but this is defunct.