Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint converter to use arguments before default behavior of checking yaml #392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpmcd
Copy link

@jpmcd jpmcd commented Mar 13, 2024

Script ignores HF_model_path_or_name argument even if supplied and skips to getting model name from yaml file. Test if argument exists before using default approach.

Unfortunately specifying a path causes the script to break.

What does this PR do?

This fixes the faulty default behavior of the converter script.

Fixes # (issue)
No issue

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

No tests needed.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 馃帀!

Script ignores `HF_model_path_or_name` argument even if supplied and skips to getting model name from yaml file. Test if argument exists before using default approach.
@facebook-github-bot
Copy link

Hi @jpmcd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@jpmcd
Copy link
Author

jpmcd commented Mar 15, 2024

@HamidShojanazeri This commit is tiny enough that you can probably look at the 1 line change + block indent and duplicate it on the main branch. Then just delete this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants